From 9ca5716a2cc182cdb0805d89e2897be9e136ae9d Mon Sep 17 00:00:00 2001 From: Andrew Suzuki Date: Thu, 2 Jun 2016 08:38:33 -0400 Subject: [PATCH] move header stuff into separate ns --- .../ulysses/components/{misc.cljs => header.cljs} | 15 ++++++++++++++- src/cljs/ulysses/components/layout.cljs | 5 ++--- src/cljs/ulysses/handlers.cljs | 2 +- src/cljs/ulysses/pages/builder.cljs | 11 ++++++++--- 4 files changed, 25 insertions(+), 8 deletions(-) rename src/cljs/ulysses/components/{misc.cljs => header.cljs} (74%) diff --git a/src/cljs/ulysses/components/misc.cljs b/src/cljs/ulysses/components/header.cljs similarity index 74% rename from src/cljs/ulysses/components/misc.cljs rename to src/cljs/ulysses/components/header.cljs index c02ad01..c03887a 100644 --- a/src/cljs/ulysses/components/misc.cljs +++ b/src/cljs/ulysses/components/header.cljs @@ -1,8 +1,12 @@ -(ns ulysses.components.misc +(ns ulysses.components.header (:require [ulysses.components.basic :refer [link fa]] [ulysses.config :as config] [re-frame.core :as re-frame :refer [subscribe]])) +;; ---------------------------------------------------------------------------- +;; sub-components +;; ---------------------------------------------------------------------------- + (defn progress [] (let [is-loading (subscribe [:is-loading]) scroll-y (subscribe [:scroll-y])] @@ -37,3 +41,12 @@ [:ul.nav.navbar-nav.red-button-menu.pull-right [uconn-banner-right-menu-item "http://uconn.edu/search" :search] [uconn-banner-right-menu-item "http://uconn.edu/az/" :sort-alpha-asc]]])) + +;; ---------------------------------------------------------------------------- +;; main +;; ---------------------------------------------------------------------------- + +(defn header [] + [:header.header + [uconn-banner] + [main-logo]]) diff --git a/src/cljs/ulysses/components/layout.cljs b/src/cljs/ulysses/components/layout.cljs index 4ca26d9..22c869e 100644 --- a/src/cljs/ulysses/components/layout.cljs +++ b/src/cljs/ulysses/components/layout.cljs @@ -1,6 +1,6 @@ (ns ulysses.components.layout (:require [reagent.core :as r] - [ulysses.components.misc :refer [uconn-banner main-logo progress]] + [ulysses.components.header :refer [header]] [ulysses.components.basic :refer [css-transition-group-standard]] [ulysses.lib.moment :as m])) @@ -10,8 +10,7 @@ (defn shell [page-name page] [:div.shell - [uconn-banner] - [main-logo] + [header] ; page [css-transition-group-standard [^{:key (name page-name)} [:div.page page]]] diff --git a/src/cljs/ulysses/handlers.cljs b/src/cljs/ulysses/handlers.cljs index 32a3a7a..4f45f46 100644 --- a/src/cljs/ulysses/handlers.cljs +++ b/src/cljs/ulysses/handlers.cljs @@ -262,7 +262,7 @@ (assoc-in db [:builder-filters :faculty-years-uconn] (or (str->int years-uconn) 0)))) -;; builder faculty workspace hover +;; builder faculty workspace hover ---- (register-handler :builder-faculties-workspace-hover diff --git a/src/cljs/ulysses/pages/builder.cljs b/src/cljs/ulysses/pages/builder.cljs index 654942b..fa22214 100644 --- a/src/cljs/ulysses/pages/builder.cljs +++ b/src/cljs/ulysses/pages/builder.cljs @@ -124,7 +124,7 @@ (map-subels pool-row faculties-and-metrics)]]])) (defn builder-panel - [grant faculties faculty-titles + [op faculties faculty-titles faculties-pool faculties-workspace faculties-workspace-hover builder-filters] @@ -146,6 +146,11 @@ [:div.inner [:h3 "Word Cloud"]]]]]) +(defn builder-header + [op] + [:div.builder-header + [:h3.text-xs-center.mb-15 (:title op)]]) + ;; ---------------------------------------------------------------------------- ;; main ;; ---------------------------------------------------------------------------- @@ -193,8 +198,8 @@ _ @page-with-args] (if op [:div - [:h3.text-xs-center.mb-15 (:title op)] - [:div [builder-panel op fa ft fp fw fh bf]]] + [builder-header op] + [builder-panel op fa ft fp fw fh bf]] [loading-or-no-results :not-found-message "The requested grant opportunity was not found."])))})))