-
Notifications
You must be signed in to change notification settings - Fork 0
Nick #14
base: dev
Are you sure you want to change the base?
Nick #14
Changes from 12 commits
b3936ca
c0b68e9
810ff1b
daa4ff9
e0b4037
f8c705d
7f6854f
d43c958
ba311d5
cabb7d4
710a12f
9de731e
6f9b08e
afceba1
edc74e0
2d08d00
b1393ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,13 +10,7 @@ | |
"cmakeCommandArgs": "", | ||
"buildCommandArgs": "-v", | ||
"ctestCommandArgs": "", | ||
"variables": [ | ||
{ | ||
"name": "CMAKE_INSTALL_PREFIX", | ||
"value": "C:/Users/Greg/Documents/git/bfs/breadcrumbs/install/basic_build", | ||
"type": "PATH" | ||
} | ||
] | ||
"variables": [] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You still need to get rid of this change |
||
} | ||
] | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#ifndef LOGGER_HPP | ||
#define LOGGER_HPP | ||
|
||
#include <stdlib.h> | ||
#include <iostream> | ||
#include <fstream> | ||
#include <string> | ||
#include <vector> | ||
#include <time.h> | ||
#include <chrono> | ||
#include <ctime> | ||
#include <windows.h> | ||
|
||
using namespace std; | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Too much space here, I know it seems kinda picky but there should just be one. |
||
|
||
extern class Logger { | ||
public: | ||
string filename; | ||
string filePath; | ||
FILE* fp; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fp, filename, and filepath should all be private |
||
Logger(int l_Level); | ||
~Logger(); | ||
void writeLog(const char* fmt, ...); | ||
static Logger* getLogger(Logger* logger); | ||
string getPath(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some of these functions can be private I think There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This getPath function should be static |
||
private: | ||
int logging_Level; | ||
//auto now; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Get rid of this space |
||
}; | ||
|
||
static Logger* logger = logger->getLogger(logger); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Get rid of this global, if we need to use the logger in the code, we can just call getLogger(). Instead, add it as a private static pointer in the class initialized to null at first. The first time getLogger is called, this private static variable will be null, so initialize it. Every other call to getLogger (after the first) will just return the pointer and NOT reinitialize it |
||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid of this change, you should not need to edit this file.