Skip to content

Bug with how I reimplemented Arithmatic #20

Merged
merged 23 commits into from May 14, 2020
Merged

Bug with how I reimplemented Arithmatic #20

merged 23 commits into from May 14, 2020

Commits on May 8, 2020

  1. Copy the full SHA
    17bdc02 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ac92532 View commit details
    Browse the repository at this point in the history
  3. Fix pull request comments

    mfs16101 committed May 8, 2020
    Copy the full SHA
    f3f13b8 View commit details
    Browse the repository at this point in the history
  4. Make edits for the pull request

    There is a problem that may be cause by these changes, that being not
    closing the handle, since the loop will run forever, I would have to
    close the loop on some sort of exit condition. I am not sure if the
    handle closes if the process is killed, if so, then I guess it should be
    fine.
    mfs16101 committed May 8, 2020
    Copy the full SHA
    2f29396 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    3cbcf6e View commit details
    Browse the repository at this point in the history
  6. Hmmm

    mfs16101 committed May 8, 2020
    Copy the full SHA
    5a9cb08 View commit details
    Browse the repository at this point in the history
  7. Revert "Hmmm"

    This reverts commit 5a9cb08.
    mfs16101 committed May 8, 2020
    Copy the full SHA
    e2ea108 View commit details
    Browse the repository at this point in the history
  8. Add functionality to get roll and pitch angles

    This reverts commit e2ea108.
    mfs16101 committed May 8, 2020
    Copy the full SHA
    98e1ba6 View commit details
    Browse the repository at this point in the history
  9. Change order of #includes fixed build errors...

    I have no idea why exactly but the build errors only got fixed when I
    changed the order of the includes in AHRSInputIOProcessor.hpp.
    mfs16101 committed May 8, 2020
    Copy the full SHA
    277cb31 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. Add Comments Explaining Byte Capture

    I added some comments explaining how I am capturing the bytes of the
    Euler Angles from the message in the buffer. Quick version here, I first
    capute a 2 times the size of the message into a buffer, I then search
    for the begining of the message, when I find it, I then jump to the
    index where the Angles are stored. I then add each group of 8 bytes for
    each angle backwords into arrays to then be converted. I add them in
    backwords since the AHRS is big endian and the computer we are
    converting them to doubles on is little endian. After each angle's 8
    bytes are storred in an array, I then cast them into doubles, where they
    can then be sent. Hopefully that makes sense, feel free to ask me any
    questions about it.
    mfs16101 committed May 10, 2020
    Copy the full SHA
    c55c91a View commit details
    Browse the repository at this point in the history
  2. Fix confusing math

    I fixed the math for getting the bytes for the Angles to make a bit easier to
    understand. I also clarfied my comments a bit to try and make them
    clearer with the explanation.
    mfs16101 committed May 10, 2020
    Copy the full SHA
    6bb6f9c View commit details
    Browse the repository at this point in the history
  3. Fix Comments More

    I further clarified my comments and also renamed index to dataStart to
    make it more clear what it was.
    mfs16101 committed May 10, 2020
    Copy the full SHA
    45ae105 View commit details
    Browse the repository at this point in the history
  4. Rename Attribute Keys

    mfs16101 committed May 10, 2020
    Copy the full SHA
    f446d77 View commit details
    Browse the repository at this point in the history
  5. Fix type in comments

    Changed "index" to "dataStart" in diagram to make it more clear.
    mfs16101 committed May 10, 2020
    Copy the full SHA
    58a3dec View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Add more specifics to Config message comments

    Matt committed May 11, 2020
    Copy the full SHA
    13c66ec View commit details
    Browse the repository at this point in the history
  2. Change arround data byte capture math

    Changed the for loop to loop backwords itself so that the equations for
    actually getting the bytes only use +'s. They are still basically the
    same equations, but hopefully they are a little more intuitive...
    mfs16101 committed May 11, 2020
    Copy the full SHA
    9988615 View commit details
    Browse the repository at this point in the history
  3. Revert "Add more specifics to Config message comments"

    This reverts commit 13c66ec.
    mfs16101 committed May 11, 2020
    Copy the full SHA
    f50c2f1 View commit details
    Browse the repository at this point in the history
  4. Revert "Change arround data byte capture math"

    This reverts commit 9988615.
    mfs16101 committed May 11, 2020
    Copy the full SHA
    596b9af View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    8ccfc65 View commit details
    Browse the repository at this point in the history
  6. Revert "Revert "Change arround data byte capture math""

    This reverts commit 596b9af.
    mfs16101 committed May 11, 2020
    Copy the full SHA
    361589d View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    63d094b View commit details
    Browse the repository at this point in the history
  8. Revert changes with arithmetic

    When I changed the arithmetic around it messed up the indexing of the
    byte arrays. The reason i went up(forward) was so that I could put it
    in the array, not to do some funky math. If we don't revert these
    changes the byte order will simply be wrong.
    mfs16101 committed May 11, 2020
    Copy the full SHA
    0965acd View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    ea0e888 View commit details
    Browse the repository at this point in the history