Skip to content

Project 3 Peer Review #1

Open
arr16112 opened this issue Apr 7, 2020 · 0 comments
Open

Project 3 Peer Review #1

arr16112 opened this issue Apr 7, 2020 · 0 comments

Comments

@arr16112
Copy link

arr16112 commented Apr 7, 2020

Hi Jake. Thanks for the feedback on my project. Here's some on yours:

Overall the project is very well organized and annotated. I noticed a few typos in your explanations, most notable in the following paragraph:

Again, we can see that the solution using the heun integration step for this rocket taking into account both gravity and drag does not converge with the simplified analysis of Tsiolkovskys equation. When we plot all three, we would expect both numerical integratiosn to follow the same trend (as they both make the same assumptions). This will be shown below.

but your analysis looks good. Besides this the only thing that I would say is that your code is redundant with all the graphs comparing everything separately and then eventually getting to a graph with the Tsiolkovsky's and two integration techniques. This isn't necessarily a bad thing and I understand the reasoning behind doing this but personally I find it overly tedious.

Overall, good job!

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant