Merge pull request #262 from benfred/memfix

Fix Memory Leak in Python Bindings.
mldrugdiscovery · Dec 11, 2017 · 4676e8d · 4676e8d
2 parents a69becb + 782b690
commit 4676e8d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/python_bindings/nmslib.cc b/python_bindings/nmslib.cc
@@ -305,6 +305,7 @@ struct IndexWrapper {
   }
 
   ~IndexWrapper() {
+    LOG(LIB_DEBUG) << "Destroying Index";
     freeObjectVector(&data);
   }
 
@@ -386,17 +387,17 @@ PYBIND11_PLUGIN(nmslib) {
       switch (dtype) {
         case DISTTYPE_FLOAT: {
           auto index = new IndexWrapper<float>(method, space, space_params, data_type, dtype);
-          ret = py::cast(index);
+          ret = py::cast(index, py::return_value_policy::take_ownership);
           break;
         }
         case DISTTYPE_DOUBLE: {
           auto index = new IndexWrapper<double>(method, space, space_params, data_type, dtype);
-          ret = py::cast(index);
+          ret = py::cast(index, py::return_value_policy::take_ownership);
           break;
         }
         case DISTTYPE_INT: {
           auto index = new IndexWrapper<int>(method, space, space_params, data_type, dtype);
-          ret = py::cast(index);
+          ret = py::cast(index, py::return_value_policy::take_ownership);
           break;
         }
         default: