Skip to content

Swe 12 enable payment suite #13

Merged
merged 14 commits into from Apr 8, 2019
Merged

Swe 12 enable payment suite #13

merged 14 commits into from Apr 8, 2019
Commits on Mar 29, 2019
  1. SWE-12 New class to handle payment result

    ahm11003 committed Mar 29, 2019
    - also changed target for `PaymentDetailInterfaceController`
  2. SWE-12 Set up Payment Result view

    ahm11003 committed Mar 29, 2019
    - we now will receive a dictionary in Payment Result which contains (for now) the payment confirmation number and payment id
    - these are displayed in the labels
  3. SWE-12 Navigation changes

    ahm11003 committed Mar 29, 2019
    - in order to avoid having a back button on the Payment Result screen, we present it modally and then pop to the root controller
    - this gives the user a view with Cancel in the left corner, and a Home button. Tapping cancel will dismiss the modal, showing the Home screen
  4. SWE-12 Use a nice slick animation

    ahm11003 committed Mar 29, 2019
    - it appears that as a result of setting the target membership of `PaymentDetailInterfaceController` to only WKExtension has enabled this function call which was not working before
Commits on Apr 2, 2019
  1. SWE-12 Support for Disclaimer screen

    ahm11003 committed Apr 2, 2019
    - also made IBOutlets `weak` to avoid retain cycles
    - we present an action sheet to the user which requires them to tape Pay Now to submit payment
    - activity indicator is shown until web service returns
    - if successful, we push to the payment result screen and show confirmation number, etc
    - if error, we ask the user to try again later
Commits on Apr 4, 2019
  1. Merge branch 'master' into SWE-12-enable-payment-suite

    ahm11003 committed Apr 4, 2019
    # Conflicts:
    #	SynchronyFinancial/SynchronyFinancial WatchKit Extension/FetchData.swift
    #	SynchronyFinancial/SynchronyFinancial.xcodeproj/project.pbxproj
Commits on Apr 5, 2019
  1. SWE-12 swiftlint warning cleanup, payment fine tweaks

    ahm11003 committed Apr 5, 2019
    - created new `enum PaymentType` to provide a cleaner way to pass code for either current balance payment or minimum due payment
  2. SWE-12 disable payment buttons in given situations

    ahm11003 committed Apr 5, 2019
    - if the minimum payment due is $0, we disable the button to allow paying that amount
    - if the current account balance is $0, we disable the button to allow paying that amount
  3. SWE-12 Remove unused “Home” button

    ahm11003 committed Apr 5, 2019
    - we now simply display “Done” as the title to dismiss the payment result screen which is presented modally
  4. SWE-12 use new date formatter

    ahm11003 committed Apr 5, 2019
    - several commits ago we created `careCreditDateFormatter`
    - replace usage of regular `DateFormatter` which require setting of format style and locale in each instance to `static` property which automatically returns the date formatter we want
You can’t perform that action at this time.