Skip to content

Swe 12 enable payment suite #13

Merged
merged 14 commits into from Apr 8, 2019
Merged

Swe 12 enable payment suite #13

merged 14 commits into from Apr 8, 2019

Commits on Mar 29, 2019

  1. SWE-12 New class to handle payment result

    - also changed target for `PaymentDetailInterfaceController`
    ahm11003 committed Mar 29, 2019
    Copy the full SHA
    3ae9792 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    2e991f6 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a2689bd View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    511f4f5 View commit details
    Browse the repository at this point in the history
  5. SWE-12 Set up Payment Result view

    - we now will receive a dictionary in Payment Result which contains (for now) the payment confirmation number and payment id
    - these are displayed in the labels
    ahm11003 committed Mar 29, 2019
    Copy the full SHA
    6f9d87c View commit details
    Browse the repository at this point in the history
  6. SWE-12 Navigation changes

    - in order to avoid having a back button on the Payment Result screen, we present it modally and then pop to the root controller
    - this gives the user a view with Cancel in the left corner, and a Home button. Tapping cancel will dismiss the modal, showing the Home screen
    ahm11003 committed Mar 29, 2019
    Copy the full SHA
    0e76bcc View commit details
    Browse the repository at this point in the history
  7. SWE-12 Use a nice slick animation

    - it appears that as a result of setting the target membership of `PaymentDetailInterfaceController` to only WKExtension has enabled this function call which was not working before
    ahm11003 committed Mar 29, 2019
    Copy the full SHA
    1b1aadd View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. SWE-12 Support for Disclaimer screen

    - also made IBOutlets `weak` to avoid retain cycles
    - we present an action sheet to the user which requires them to tape Pay Now to submit payment
    - activity indicator is shown until web service returns
    - if successful, we push to the payment result screen and show confirmation number, etc
    - if error, we ask the user to try again later
    ahm11003 committed Apr 2, 2019
    Copy the full SHA
    50d5863 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. Merge branch 'master' into SWE-12-enable-payment-suite

    # Conflicts:
    #	SynchronyFinancial/SynchronyFinancial WatchKit Extension/FetchData.swift
    #	SynchronyFinancial/SynchronyFinancial.xcodeproj/project.pbxproj
    ahm11003 committed Apr 4, 2019
    Copy the full SHA
    534958f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. SWE-12 swiftlint warning cleanup, payment fine tweaks

    - created new `enum PaymentType` to provide a cleaner way to pass code for either current balance payment or minimum due payment
    ahm11003 committed Apr 5, 2019
    Copy the full SHA
    5407b69 View commit details
    Browse the repository at this point in the history
  2. SWE-12 disable payment buttons in given situations

    - if the minimum payment due is $0, we disable the button to allow paying that amount
    - if the current account balance is $0, we disable the button to allow paying that amount
    ahm11003 committed Apr 5, 2019
    Copy the full SHA
    fff4ae0 View commit details
    Browse the repository at this point in the history
  3. SWE-12 Remove unused “Home” button

    - we now simply display “Done” as the title to dismiss the payment result screen which is presented modally
    ahm11003 committed Apr 5, 2019
    Copy the full SHA
    ed55a49 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    d4bf1b8 View commit details
    Browse the repository at this point in the history
  5. SWE-12 use new date formatter

    - several commits ago we created `careCreditDateFormatter`
    - replace usage of regular `DateFormatter` which require setting of format style and locale in each instance to `static` property which automatically returns the date formatter we want
    ahm11003 committed Apr 5, 2019
    Copy the full SHA
    be8b0cf View commit details
    Browse the repository at this point in the history