-
Notifications
You must be signed in to change notification settings - Fork 0
Swe 25 project wide cleanup #18
Open
ahm11003
wants to merge
9
commits into
master
Choose a base branch
from
SWE-25-project-wide-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 24, 2019
-
SWE-25 change pattern for account
- we eliminated the storyboard segue in favor of “pushing” either Account Details of the Accounts table, depending on number of accounts present - we simply pass an `[Account]` to AccountDetails - updated this change in context to be reflected in Account Table as well - removed unused boilerplate code in these classes as well
Configuration menu - View commit details
-
Copy full SHA for a688900 - Browse repository at this point
Copy the full SHA a688900View commit details -
SWE-25 update change in context usage
- made changes in AccountDetails and PayBill interface controllers to be more simple, passing only the applicable `Account` - removed unused boilerplate code
Configuration menu - View commit details
-
Copy full SHA for 8269068 - Browse repository at this point
Copy the full SHA 8269068View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9e055b - Browse repository at this point
Copy the full SHA d9e055bView commit details
Commits on May 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 11b4385 - Browse repository at this point
Copy the full SHA 11b4385View commit details -
Configuration menu - View commit details
-
Copy full SHA for 186e970 - Browse repository at this point
Copy the full SHA 186e970View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5c008a - Browse repository at this point
Copy the full SHA a5c008aView commit details -
SWE-25 fix bug preventing accounts from being passed to wellness
- since we simplified earlier how we pass around accounts, we need to update how we look for the to be sent from Wellness
Configuration menu - View commit details
-
Copy full SHA for 582b7a5 - Browse repository at this point
Copy the full SHA 582b7a5View commit details -
SWE-25 fix error causing incorrect transaction list
- for transactions other than processed purchases, `transactionCode` is `NULL` from the server - the existing logic was causing all other transactions (payments, all processing transactions) to not be parsed and collected on our end - fixed this issue by grabbing `transactionCode` in a non-conditional way to ensure we get all transactions
Configuration menu - View commit details
-
Copy full SHA for 06f4a75 - Browse repository at this point
Copy the full SHA 06f4a75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c76ad5 - Browse repository at this point
Copy the full SHA 4c76ad5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.