Skip to content

Added dropdown menu #2

Merged
merged 5 commits into from Mar 27, 2020
Merged

Added dropdown menu #2

merged 5 commits into from Mar 27, 2020

Conversation

jos15101
Copy link
Contributor

Added dropdown menu to select XA models

@jos15101 jos15101 added the enhancement New feature or request label Mar 25, 2020
@jos15101 jos15101 requested a review from dds14002 March 25, 2020 21:50
@jos15101 jos15101 self-assigned this Mar 25, 2020
Copy link
Contributor

@dds14002 dds14002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: end item = XA

  1. The dropdown should not be a part of the tree component. The tree will be generated based on which end item is selected. Note that the selected end item is a system wide property and not isolated to the tree.
  • The dropdown should be generated from a hardcoded array in the ts file, not directly in the html file. This is because we will eventually be pulling this information from the backend.
  1. You should make a service to keep track of the selected end item. The tree should be listening to that service and regenerate itself whenever the end item value changes.

src/app/main/tree/tree.component.html Outdated Show resolved Hide resolved
src/app/main/tree/tree.component.ts Outdated Show resolved Hide resolved
src/app/main/tree/tree.component.html Outdated Show resolved Hide resolved
@jos15101 jos15101 requested a review from dds14002 March 26, 2020 21:33
@dds14002 dds14002 merged commit 6731720 into develop Mar 27, 2020
@jos15101 jos15101 deleted the selectionDropDown branch March 27, 2020 00:42
Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants