Development #1
Merged
Development #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eal13009
reviewed
Apr 29, 2019
src/app/header/header.component.ts
Outdated
| @@ -23,6 +23,17 @@ export class HeaderComponent implements OnInit { | |||
| resetGenAndVisualize() { | |||
| this.resetAndRedirect('/visualize-all'); | |||
| } | |||
| isLoggedIn() | |||
There was a problem hiding this comment.
What is the logic behind this function? A user being logged in shouldn't be dictated by the router url, as anyone can have a link to a URL and suddenly be shown icons as if they were logged in.
There was a problem hiding this comment.
Modified isLoggedIn() to check for auth_token availability instead. Let me know if that is a good solution or not
… removes auth token on init
|
Found logic error with redirect, don't merge please |
eal13009
approved these changes
May 1, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hover effects, header adjustments depending if you are logged in, and changed graph button on statistics page