Memory leak in space_sparse_vector_inter.cc #165

mldrugdiscovery · Jul 20, 2017 · 5b12955 · 5b12955
1 parent 090e6f7
commit 5b12955
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/similarity_search/src/space/space_sparse_vector_inter.cc b/similarity_search/src/space/space_sparse_vector_inter.cc
@@ -55,13 +55,10 @@ Object* SpaceSparseVectorInter<dist_t>::CreateObjFromVect(IdType id, LabelType l
   char    *pData = NULL;
   size_t  dataLen = 0;
 
-  try {
-    PackSparseElements(InpVect, pData, dataLen);
-    return new Object(id, label, dataLen, pData);
-  } catch (...) {
-    delete [] pData;
-    throw;
-  }
+  PackSparseElements(InpVect, pData, dataLen);
+  unique_ptr<char[]>  data(pData);
+  unique_ptr<Object> obj(new Object(id, label, dataLen, data.get()));
+  return obj.release();
 }
 
 template <typename dist_t>