Skip to content

Swe 13 choose bank account #15

Merged
merged 12 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@rrk12005
Copy link
Owner

rrk12005 commented Apr 7, 2019

This branch allows the user to choose the bank they want to use. Need to hook up to the makePayment API call

rrk12005 added some commits Apr 5, 2019

Created PaymentOptions interface and controller for selecting payment…
… type. Fetching bank account info and populating table with it. Updated getbankacctinfo request to grab the bank name and last 4 digits of bank account.
reated PaymentOptions interface and controller for selecting payment …
…type. Fetching bank account info and populating table with it. Updated getbankacctinfo request to grab the bank name and last 4 digits of bank account.
SWF-13 able to choose bank that user would like to pay for. No passin…
…g of account info, just able to display chosen bank name
SWF-13 finished addition of ability to choose bank account to pay for…
…. new structure of storing default bank account in UseraDefaults

@rrk12005 rrk12005 requested review from ahm11003, jod13004 and tiw15001 Apr 7, 2019

@ahm11003
Copy link
Collaborator

ahm11003 left a comment

Overall this PR looks good. A few changes need to be made before it is ready to merge. Also, is it possible to populate the bank account and only fire off the web service if the user wants to change that account?

Merge branch 'master' into SWE-13-choose-bank-account
# Conflicts:
#	SynchronyFinancial/SynchronyFinancial WatchKit App/Base.lproj/Interface.storyboard
#	SynchronyFinancial/SynchronyFinancial WatchKit Extension/FetchData.swift
#	SynchronyFinancial/SynchronyFinancial WatchKit Extension/PaymentDetailInterfaceController.swift
#	SynchronyFinancial/SynchronyFinancial/Defaults.swift
@ahm11003

This comment has been minimized.

Copy link
Collaborator

ahm11003 commented Apr 8, 2019

Additionally, when we currently make a payment we pass in the last 4 digits of the bank account to pay from. So, we should either update that function to retrieve the value stored in UserDefaults and remove that parameter, or we should update existing calls to the make payment function to retrieve the value from UserDefaults prior to making the call.

rrk12005 added some commits Apr 8, 2019

Fixed errors from code review. Additionally, moved where fetchBankInf…
…o API request is called so it is fired upon only when user want to change default bank acct. User's default bank account ID is now being used in the makePayment API call.
}
bankAccts = accts
configureRows()
}

This comment has been minimized.

Copy link
@ahm11003

ahm11003 Apr 8, 2019

Collaborator

insert new line after this closing brace

ahm11003 and others added some commits Apr 9, 2019

Merge branch 'master' into SWE-13-choose-bank-account
# Conflicts:
#	SynchronyFinancial/SynchronyFinancial WatchKit Extension/TransactionsInterfaceController.swift
#	SynchronyFinancial/SynchronyFinancial.xcodeproj/project.pbxproj
SWE-13 Integration of UserDefaults+Extension as the getter for bankAc…
…ctInfo from UserDefaults in updating the selected bank account label as well as passing bankId in submit payment

@ahm11003 ahm11003 merged commit 8d33cc1 into master Apr 10, 2019

Sign in to join this conversation on GitHub.
You can’t perform that action at this time.