Skip to content

Swf 17 credit health #17

merged 26 commits into from May 1, 2019

Swf 17 credit health #17

merged 26 commits into from May 1, 2019


Copy link

ahm11003 commented Apr 24, 2019

  • remove unused metrics
  • created and implemented new metrics for credit utilization, comparison to last month's utilization, average utilization (for multi acct), number of healthy accounts (multi acct), and last payment trend
  • some calculations and weights for determining "overall" wellness score are preliminary and subject to change
ahm11003 and others added 26 commits Feb 13, 2019
- added image assets and code to demo a radial progress indicator
- set up some basic wireframe page-based nav
- app icon assets
…tUtil to attempt to read created plist named Property List.
- change plist structure to array for easier reading from plist
- populate radial indicators with values
- set up check to only animate once

Demo radial style progress indicators
…ial indicator to match the others. Added metric for late payments and number of accounts.
# Conflicts:
#	SynchronyFinancial/SynchronyFinancial WatchKit App/Base.lproj/Interface.storyboard
#	SynchronyFinancial/SynchronyFinancial.xcodeproj/project.pbxproj
- Added identifiers for wellness score controllers
- Added "transaction_code" values to respective API call and transaction class
- this was removed in favor of instantiating our page view hierarchy programatically
- added `IBAction` to handle tap events from `Tap For More` button
- removed call to push UtilizationScore
- uncomment switch statement on late payments
- dynamically resize the radial indicator to allow showing a button below to explain the metric
- recolored some buttons on account details screen
- also removed unused instances and references to this class, as well as related logic to power it
- currently we generate a random number between 0 and the credit limit of an account in order to “simulate” trend compared to previous statement utilization
- added some nice images to further display the trends
# Conflicts:
#	SynchronyFinancial/SynchronyFinancial WatchKit Extension/FetchData.swift
#	SynchronyFinancial/SynchronyFinancial.xcodeproj/project.pbxproj
- remove deprecated `PaymentScore` and all related logic to calculate this metric
- added classes `AvgUtilization`, `HealthyAccounts`, and `LastPayment` interface controllers to display more metrics and add dynamic reports for users with multiple accounts
- added outlets for metric objects
- configured other UI elements
- also changed `wellnessScore` to not be optional
- added static defaults for the “blurbs” used to describe wellness metrics
- used these in our new and existing metrics descriptions
- implemented passing of values to `AvgUtilization` and `HealthyAccounts` metrics
- set up calculation for these metrics in Wellness as well
- modified `Account` object model to contain `lastPayment` value to drive the last payment metric
- modified our account fetch to retrieve this value from the servers
- remove unused `Account` properties
- finished implementation for new wellness metrics
- added some validation to ensure we get the value we want
- else, we have changed score to not be optional
- removed unused overridden boilerplate functions
@ahm11003 ahm11003 requested review from rrk12005, jod13004 and tiw15001 Apr 24, 2019
Copy link

rrk12005 left a comment

look's good

@ahm11003 ahm11003 merged commit d169bdf into master May 1, 2019
Sign in to join this conversation on GitHub.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.