Swf 11 recent transactions #9
Merged
+112
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disabled rules for silly things like line length and short identifier names - don’t run swiftlint in our pods directory, since we shouldn’t be changing anything there
- these can be removed as a result of adding .swiftlint.yml
Swf 14 swiftlint improvements
- `TransactionsInterfactController` will hold a table of recent transactions - `TransactionCell` provides a model for our table cell
- Added TransactionsInterfaceController - In order to have a page based navigation allowing swipe between Account Details and Transactions, it was necessary to change the segue from the Accounts Table to “modal” type
- As a result of the change to modal presentation, the function we must override has changed - Instead of returning the context for the next interface controller, we return an array of contexts, each corresponding to the interface controllers in the order they appear in the navigation stack (Account details is first, transactions is now second) - once web service is set up, transactions should be passed to TransactionsInterfactController from this function
rrk12005
approved these changes
Mar 26, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for Transactions UI