Skip to content

Commit

Permalink
swc-installation-test-2.py: Don't override Popen's 'close_fds'
Browse files Browse the repository at this point in the history
Or 'shell'.  The support for these options can be flaky, and the
defaults change with Python version depending on what is best
supported [1].

[1]: http://docs.python.org/2/library/subprocess.html#subprocess.Popen

Reported-by: Ethan White <ethan@weecology.org>
  • Loading branch information
W. Trevor King committed Mar 8, 2013
1 parent 2f27dfa commit 1ba97b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup/swc-installation-test-2.py
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ def _get_version_stream(self, stdin=None, expect=(0,)):
p = _subprocess.Popen(
[command] + list(self.version_options), stdin=popen_stdin,
stdout=_subprocess.PIPE, stderr=_subprocess.PIPE,
close_fds=True, shell=False, universal_newlines=True)
universal_newlines=True)
except OSError as e:
raise DependencyError(
checker=self,
Expand Down

0 comments on commit 1ba97b9

Please sign in to comment.