Skip to content

Commit

Permalink
swc-installation-test-2.py: Add minimum browser requirements for IPython
Browse files Browse the repository at this point in the history
IPython notebooks (at least for version 1.2.1 [1], 2.3.0 [2], and
3.0.0 [3]) have the following minimum browser requirements:

    Chrome ≥ 13
    Safari ≥ 5
    Firefox ≥ 6

Due to the notebook's usage of WebSockets and the flexible box model
[1,2,3].  This commit ensures that folks requiring IPython have a
notebook-compatible browser.

We don't actually check the Safari version, because I'm not sure what
the appropriate command-line switch is to get it to print version
information.

[1]: http://ipython.org/ipython-doc/1/install/install.html#browser-compatibility
[2]: http://ipython.org/ipython-doc/2/install/install.html#browser-compatibility
[3]: http://ipython.org/ipython-doc/dev/install/install.html#browser-compatibility
  • Loading branch information
W. Trevor King committed Jan 24, 2015
1 parent 3ffcd71 commit d13b26c
Showing 1 changed file with 42 additions and 1 deletion.
43 changes: 42 additions & 1 deletion swc-installation-test-2.py
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,48 @@ def _program_files_paths(*args):
('jinja2', 'jinja', 'Jinja', (2, 6), None),
('zmq', 'pyzmq', 'PyZMQ', (2, 1, 4), None),
('IPython', None, 'IPython Python package',
CHECKER['ipython'].minimum_version, ['jinja', 'tornado', 'pyzmq']),
CHECKER['ipython'].minimum_version, [
'jinja',
'tornado',
'pyzmq',
VirtualDependency(
name='virtual-browser-ipython',
long_name='IPython-compatible web browser',
or_dependencies=[
CommandDependency(
command=CHECKER['firefox'].command,
paths=CHECKER['firefox'].paths,
name='{0}-for-ipython'.format(
CHECKER['firefox'].name),
long_name='{0} for IPython'.format(
CHECKER['firefox'].long_name),
minimum_version=(6, 0)),
CommandDependency(
command=CHECKER['google-chrome'].command,
paths=CHECKER['google-chrome'].paths,
name='{0}-for-ipython'.format(
CHECKER['google-chrome'].name),
long_name='{0} for IPython'.format(
CHECKER['google-chrome'].long_name),
minimum_version=(13, 0)),
CommandDependency(
command=CHECKER['chromium'].command,
paths=CHECKER['chromium'].paths,
name='{0}-for-ipython'.format(
CHECKER['chromium'].name),
long_name='{0} for IPython'.format(
CHECKER['chromium'].long_name),
minimum_version=(13, 0)),
PathCommandDependency(
command=CHECKER['safari'].command,
paths=CHECKER['safari'].paths,
name='{0}-for-ipython'.format(
CHECKER['safari'].name),
long_name='{0} for IPython'.format(
CHECKER['safari'].long_name),
minimum_version=(5, 0)),
]),
]),
('argparse', None, 'Argparse', None, None),
('numpy', None, 'NumPy', None, None),
('scipy', None, 'SciPy', None, None),
Expand Down

0 comments on commit d13b26c

Please sign in to comment.