John b #5
Merged
John b #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests for the Player's inventory. Added _quantity variable to Item class. We will discuss whether or not to keep this at our meeting
every method. This helps to organize our other comments and keep them "within" each method. The Javadoc serves as a title for each method and outlines what each method does. I have also made changes to variable names in an effort to make them more descriptive and appropriate. We can discuss all of these changes during our meeting and decide whether or not they will be beneficial.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Merchant class is the one pulled from Gavn, let me pull from this branch and I'll try and find some problems if there are any.