Swf 21 hook up to web apis #11
Merged
+14,598
−247
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
79afbdf
SWF-21 [cocoapods] install Alamofire
ahm11003 ff0b413
Merge branch 'master' into SWF-21-hook-up-to-web-apis
ahm11003 f2a8883
SWF-21 [cocoapods] install SwiftyJSON
ahm11003 e85d2cb
SWF-21 initial web service setup
ahm11003 da5294a
Updated Accounts Model and created request to Multi-Account-Summary-D…
rrk12005 a2599ec
Quick Fix for bug where request not parsing payload JSON
rrk12005 ba4409d
SWF-21 improve login logic & more
ahm11003 8405351
Merge branch 'master' into SWF-21-hook-up-to-web-apis
ahm11003 c80231e
SWF-21 pass fetched accounts to AccountTVIC
ahm11003 c4cc995
SWF-21 Modified header for transactions fetch
ahm11003 21d742c
SWF-21 preliminary fetch function for transactions
ahm11003 8487ce3
SWF-21 Initial transaction implementation
ahm11003 24deb73
SWF-21 Initial setup for “loading” during account tap
ahm11003 a3682e4
SWF-21 basic paradigm for passing account data to root interface cont…
ahm11003 56caa7c
SWF-21 Extensions on WKInterfaceImage
ahm11003 2c01f37
SWF-21 Replace alerts with new activity indicator
ahm11003 82d2319
SWF-21 Remove unused code
ahm11003 28a7fc1
Merge branch 'master' into SWF-21-hook-up-to-web-apis
ahm11003 3ee46a5
SWF-21 move fetch transactions call
ahm11003 6bedc02
SWF-21 UI fixes
ahm11003 00d3583
SWF-21 Care credit image assets, loading label
ahm11003 d5f19aa
Added requests and handlers for fetching pending transactions, fetchi…
rrk12005 86153df
fixed constructor implementation for transaction and added newline af…
rrk12005 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // | ||
| // Banks.swift | ||
| // SynchronyFinancial | ||
| // | ||
| // Created by Rahul Kantesaria on 4/2/19. | ||
| // Copyright © 2019 Alan Maynard. All rights reserved. | ||
| // | ||
| import Foundation | ||
|
|
||
| public enum AccountType: Int { | ||
| case checkings = 0 | ||
| case savings = 1 | ||
| } | ||
| class BankAcct: NSObject { | ||
| var bankAcctId: String | ||
| var acctType: AccountType | ||
| init(bankAcctId: String, acctType: AccountType) { | ||
| self.bankAcctId = bankAcctId | ||
| self.acctType = acctType | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,11 +17,33 @@ class Transaction: NSObject { | |
| var amount: Double | ||
| var merchantID: String | ||
| var date: Date | ||
| var confirmationNum: String | ||
| var paymentId: Int | ||
| var isPending: Bool | ||
| var isModifiable: Bool | ||
|
|
||
| init(type: TransactionType, amount: Double, merchantID: String, date: Date) { | ||
| //this constructor is for the case if it is a posted transaction | ||
| init(type: TransactionType, amount: Double, merchantID: String, date: Date, isPending: Bool) { | ||
| self.type = type | ||
| self.amount = amount | ||
| self.merchantID = merchantID | ||
| self.date = date | ||
| self.confirmationNum = "" | ||
| self.paymentId = 0 | ||
| self.isPending = isPending | ||
| self.isModifiable = false | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So we should only need one initializer for this class. We can achieve this like: This way we can choose to pass in values for |
||
| //this constructor is for the case if it is a pending transaction | ||
| init(type: TransactionType, amount: Double, merchantID: String, date: Date, | ||
| confirmationNum: String, paymentId: Int, isPending: Bool, isModifiable: Bool) { | ||
| self.type = type | ||
| self.amount = amount | ||
| self.merchantID = merchantID | ||
| self.date = date | ||
| self.confirmationNum = confirmationNum | ||
| self.paymentId = paymentId | ||
| self.isPending = isPending | ||
| self.isModifiable = isModifiable | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline after this closing brace for the
enum