Swe 25 project wide cleanup #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we eliminated the storyboard segue in favor of “pushing” either Account Details of the Accounts table, depending on number of accounts present - we simply pass an `[Account]` to AccountDetails - updated this change in context to be reflected in Account Table as well - removed unused boilerplate code in these classes as well
- made changes in AccountDetails and PayBill interface controllers to be more simple, passing only the applicable `Account` - removed unused boilerplate code
- since we simplified earlier how we pass around accounts, we need to update how we look for the to be sent from Wellness
- for transactions other than processed purchases, `transactionCode` is `NULL` from the server - the existing logic was causing all other transactions (payments, all processing transactions) to not be parsed and collected on our end - fixed this issue by grabbing `transactionCode` in a non-conditional way to ensure we get all transactions
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up, bug fixes, and new image assets