Skip to content

Swe 25 project wide cleanup #18

Open
wants to merge 9 commits into
base: master
from
Open

Conversation

@ahm11003
Copy link
Collaborator

ahm11003 commented May 2, 2019

clean up, bug fixes, and new image assets

ahm11003 added 8 commits Apr 24, 2019
- we eliminated the storyboard segue in favor of “pushing” either Account Details of the Accounts table, depending on number of accounts present
- we simply pass an `[Account]` to AccountDetails
- updated this change in context to be reflected in Account Table as well
- removed unused boilerplate code in these classes as well
- made changes in AccountDetails and PayBill interface controllers to be more simple, passing only the applicable `Account`
- removed unused boilerplate code
- since we simplified earlier how we pass around accounts, we need to update how we look for the to be sent from Wellness
- for transactions other than processed purchases, `transactionCode` is `NULL` from the server
- the existing logic was causing all other transactions (payments, all processing transactions) to not be parsed and collected on our end
- fixed this issue by grabbing `transactionCode` in a non-conditional way to ensure we get all transactions
@ahm11003 ahm11003 requested review from rrk12005, jod13004 and tiw15001 May 2, 2019
Sign in to join this conversation on GitHub.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.